cesium/cesium-plot-js
1
0
Fork 0
mirror of https://github.com/ethan-zf/cesium-plot-js.git synced 2025-11-04 01:04:18 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Temporary fix for performance issues caused by CallbackProperty

Browse Source
This commit is contained in:
ethan 2023-08-25 18:01:18 +08:00
parent 500259c7fb
commit badc4a57cd
1 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/base.ts
View File

@ -151,6 +151,24 @@ export default class Base {
finishDrawing() {
this.removeMoveListener();
this.setState('static');
/**
* "I've noticed that CallbackProperty can lead to significant performance issues.
* After drawing multiple shapes, the map becomes noticeably laggy. Using methods
* like requestAnimationFrame or setInterval doesn't provide a smooth way to display
* shapes during the drawing process. As a temporary solution, I've set the hierarchy
* or positions to static after drawing is complete. This addresses the performance
* problem, but introduces a new issue: after setting the data to static, the shapes
* redraw, resulting in a flicker. However, this seems to be a relatively reasonable
* approach given the current circumstances."
*/
if (this.type === 'polygon') {
this.polygonEntity.polygon.hierarchy = new this.cesium.PolygonHierarchy(this.geometryPoints);
this.outlineEntity.polyline.positions = [...this.geometryPoints, this.geometryPoints[0]];
} else if (this.type === 'line') {
this.lineEntity.polyline.positions = this.geometryPoints;
}
this.eventDispatcher.dispatchEvent('drawEnd', this.getPoints());
}
@ -384,7 +402,7 @@ export default class Base {
getPoints(): CesiumTypeOnly.Cartesian3[] {
//Abstract method that must be implemented by subclasses.
return this.cesium.Cartesian3();
return [new this.cesium.Cartesian3()];
}
updateMovingPoint(cartesian: CesiumTypeOnly.Cartesian3, index?: number) {